CHadamard #1114
Merged
CHadamard #1114
+262
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
reviewed
Jul 9, 2024
|
|
||
| @cached_property | ||
| def signature(self) -> 'Signature': | ||
| return Signature.build(ctrl=1, q=1) |
There was a problem hiding this comment.
ditto: should we rename to ctrl and target instead?
tanujkhattar
approved these changes
Jul 9, 2024
| # This is based on the decomposition provided by `cirq.decompose_multi_controlled_rotation` | ||
| # which uses three cirq.MatrixGate's to do a controlled version of any single-qubit gate. | ||
| # The first MatrixGate happens to be a clifford, Hadamard operation in this case. | ||
| # The other two are considered 'rotations'. |
There was a problem hiding this comment.
Please link #237 in the comments so we can update the T-complexity at a later point.
|
At long last I have made the requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the controlled-hadamard
CHadamardbloq. This will be a leaf bloq #873 and specialized compilations should be relegated to the architecture-specific models #237Basic gates #1109